Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Oppdatert Search escape håndtering #2245

Merged
merged 1 commit into from
Sep 7, 2023
Merged

♻️ Oppdatert Search escape håndtering #2245

merged 1 commit into from
Sep 7, 2023

Conversation

KenAJoh
Copy link
Collaborator

@KenAJoh KenAJoh commented Sep 6, 2023

Description

Search-komponent kjører i dag e.preventDefault() ved alle Escape-keydown. Dette skaper problemer ved bruk av f.eks Modal. Løsning er å bare kjøre preventDefault når det faktisk er innhold å slette i search-input (følger da native-oppførsel)

Change summary

  • Flyttet onKeydown event fra eventlistener til div-wrapper
  • Kjører preventDefault bare når input har tekstinnhold

@changeset-bot
Copy link

changeset-bot bot commented Sep 6, 2023

🦋 Changeset detected

Latest commit: f91af70

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/ds-react Patch
@navikt/ds-css Patch
@navikt/ds-tokens Patch
@navikt/ds-tailwind Patch
@navikt/aksel-icons Patch
@navikt/aksel Patch
@navikt/aksel-stylelint Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Storybook demo

57e9a5bc5 | 54 komponenter | 356 stories

@KenAJoh KenAJoh merged commit 2989853 into main Sep 7, 2023
@KenAJoh KenAJoh deleted the search-events branch September 7, 2023 10:41
@github-actions github-actions bot mentioned this pull request Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant