Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚨 Forbedret ESLint-oppsett #2265

Merged
merged 51 commits into from
Sep 14, 2023
Merged

🚨 Forbedret ESLint-oppsett #2265

merged 51 commits into from
Sep 14, 2023

Conversation

HalvorHaugan
Copy link
Contributor

@HalvorHaugan HalvorHaugan commented Sep 8, 2023 •
edited
Loading

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Sep 8, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 14d8522

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/ds-react Minor
@navikt/ds-css Minor
@navikt/ds-tokens Minor
@navikt/ds-tailwind Minor
@navikt/aksel-icons Minor
@navikt/aksel Minor
@navikt/aksel-stylelint Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023 •
edited
Loading

Storybook demo

2737d7abc | 57 komponenter | 372 stories

HalvorHaugan and others added 19 commits September 8, 2023 14:55
@HalvorHaugan
fiks fiks
3707e8b
@HalvorHaugan
fjern unødvendige overrides, legg til storybook-plugin
9087e74
@HalvorHaugan
Unngå eslint-disable react-hooks/rules-of-hooks
db77f84
@HalvorHaugan
Fjern eslint-stats
48a75c1
@KenAJoh
🔥 Fjernet re-export av aksel logo
f7e9064
@KenAJoh
🐛 Fjernet unødvendig optional-chaning
636e81f
@KenAJoh
🐛 Fjernet require-import i tailwind
3ecb89f
@KenAJoh
🎨 Allowcomputed i randomicons
3cddb50
@KenAJoh
🐛 Togglegroup videresender nå id riktig
4fdd524
@KenAJoh
🎨 omit children fra loader
298c93a
@KenAJoh
🎨 Omit children fra useCheckbox
a1bbcdc
@KenAJoh
🔥 Fjernet unødvendig test
7046b56
@KenAJoh
🎨 Bedre assertion av htmlSize i select
f8c4227
@KenAJoh
🏷️ Bedre export av typer i dropdown
5a2f3ff
@KenAJoh
🐛 datepicker tester
5eb999b
@KenAJoh
🔥 fjernet unødvendig test
036ad1e
@KenAJoh
🎨 Omit children og id fra datepickerstandalone
11c5b0c
@KenAJoh
🎨 Omit onClick fra accordionItem
ada53af
@KenAJoh
♻️ bruker const i css-imports
bae26fd
@HalvorHaugan HalvorHaugan marked this pull request as ready for review September 12, 2023 12:30
JulianNymark
JulianNymark previously approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@JulianNymark JulianNymark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩

KenAJoh
KenAJoh previously approved these changes Sep 13, 2023
View reviewed changes
Copy link
Collaborator

@KenAJoh KenAJoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 👏 👏 👏

it-vegard
it-vegard approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@it-vegard it-vegard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Ser bra ut, og har fått sjekket alle eksempler av Combobox uten å finne noen funksjonelle endringer eller endret HTML der.

@HalvorHaugan HalvorHaugan merged commit 95ce972 into main Sep 14, 2023
@HalvorHaugan HalvorHaugan deleted the eslint-update branch September 14, 2023 12:39
@github-actions github-actions bot mentioned this pull request Sep 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JulianNymark JulianNymark JulianNymark left review comments

@KenAJoh KenAJoh KenAJoh approved these changes

@it-vegard it-vegard it-vegard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HalvorHaugan @JulianNymark @it-vegard @KenAJoh