ActionMenu component #3081
Merged
ActionMenu component #3081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lektert i descendants-map
HalvorHaugan
reviewed
Oct 7, 2024
HalvorHaugan
reviewed
Oct 7, 2024
HalvorHaugan
reviewed
Oct 7, 2024
Co-authored-by: Halvor Haugan <[email protected]>
Co-authored-by: Halvor Haugan <[email protected]>
Co-authored-by: Halvor Haugan <[email protected]>
HalvorHaugan
previously approved these changes
Oct 8, 2024
* memo: ActionMenu documentation * refactor: Update to use Icons * bug: Fixed use of Item with nextjs link-component * memo: Updated examples * memo: Updated examples, removed div-wrapper * TODOS * memo: Oppdatert submenu med table-vising * feat: Oppdatert eksempler * memo: Default open first submenu in demo * memo: Use norwegian in link docs * Update aksel.nav.no/website/pages/eksempler/actionmenu/shortcuts.tsx Co-authored-by: Halvor Haugan <[email protected]> * memo: Shortcut easter egg * ⚡ Simplify indeterminate toggle for actionmenu * refactor: remove redundant aria-label * Update aksel.nav.no/website/pages/eksempler/actionmenu/sub-menu.tsx Co-authored-by: Halvor Haugan <[email protected]> * Update aksel.nav.no/website/pages/eksempler/actionmenu/links.tsx Co-authored-by: Halvor Haugan <[email protected]> * memo: removed reference to nextjs app-router * bug: Removed empty aria-label --------- Co-authored-by: Halvor Haugan <[email protected]>
* bug: Fixed scroll + wrapping issue * bug: undo scrollbar gutter change
|
This bug only happens when they all are defaultOpen. In that case the "last submenu" is first in the DOM, thus Getting lower z-index. In actual use this won't happen since each submenu comes after "main" content in dom. We could in theory increment the z-index based on "level", but don't think that is necessary 
|
HalvorHaugan
previously approved these changes
Oct 11, 2024
Co-authored-by: Halvor Haugan <[email protected]>
HalvorHaugan
approved these changes
Oct 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ActionMenu will act as new and improved replacement for our
Dropdown, with functionality forTODO:
Examples and demonstrations for the website will be a new PR after this one is completed.