-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ErrorSummary: Remove aria-attributes #3171
Conversation
🦋 Changeset detectedLatest commit: 73214f0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Storybook demo986456f8a | 90 komponenter | 141 stories |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we gain anything by removing section + removing aria-labelledby
connection? Do we consider the section/region semantics redundant for screen-readers since the heading is the same?
We avoid that some screen readers reads the heading twice (once as the section name, and once as the heading). @mortentollefsen and @it-vegard discussed this on Monday, and as I remember it, there wasn't really any strong arguments on either side. |
Most users will navigate by heading, so we don't give up a lot to avoid the double announcement. I would have liked having the section there if we continued to focus the section. When moving focus to the heading instead, the value of having the named section is almost gone. Only when navigating with reading mode would it still be useful, but even then the value is low. Less aria is also <3 |
Description
Closes https://github.com/navikt/team-aksel/issues/637
Component Checklist 📝
@navikt/core/css/config/_mappings.js
)@navikt/core/css/tokens.json
)@navikt/aksel-stylelint/src/deprecations.ts
)@navikt/core/react/src/index.ts
and@navikt/core/react/package.json
)@navikt/core/css/index.css
)<Component>: <gitmoji?> <Text>.
E.g. "Button: ✨ Add feature xyz.")