Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List: ✨ New size 'large' #3207

Merged
merged 3 commits into from
Oct 8, 2024
Merged

List: ✨ New size 'large' #3207

merged 3 commits into from
Oct 8, 2024

Conversation

HalvorHaugan
Copy link
Contributor

@HalvorHaugan HalvorHaugan commented Oct 8, 2024

Description

Closes https://github.com/navikt/team-aksel/issues/641

Component Checklist 📝

  • JSDoc
  • Examples
  • Documentation
  • Storybook
  • Style mappings (@navikt/core/css/config/_mappings.js)
  • Component tokens (@navikt/core/css/tokens.json)
  • CSS class deprecations (@navikt/aksel-stylelint/src/deprecations.ts)
  • Exports (@navikt/core/react/src/index.ts and @navikt/core/react/package.json)
  • New component? CSS import (@navikt/core/css/index.css)
  • Breaking change? Update migration guide. Consider codemod.
  • Changeset (Format: <Component>: <gitmoji?> <Text>. E.g. "Button: ✨ Add feature xyz.")

Copy link

changeset-bot bot commented Oct 8, 2024

🦋 Changeset detected

Latest commit: 93016b7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/ds-react Minor
@navikt/ds-css Minor
@navikt/ds-tokens Minor
@navikt/ds-tailwind Minor
@navikt/aksel-icons Minor
@navikt/aksel Minor
@navikt/aksel-stylelint Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 8, 2024

Storybook demo

Endringer til review: 1

138c27e13 | 90 komponenter | 141 stories

Copy link
Collaborator

@KenAJoh KenAJoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

While not related to this PR

    const { size: contextSize } = useContext(ListContext);
    const listSize = size ?? contextSize;

One can now in theory have two different sizes when nesting the list, should the "parent" list override this?

@HalvorHaugan
Copy link
Contributor Author

LGTM

While not related to this PR

    const { size: contextSize } = useContext(ListContext);
    const listSize = size ?? contextSize;

One can now in theory have two different sizes when nesting the list, should the "parent" list override this?

I think that's a design question, but personally I think it's nice to be able to e.g. have a nested list that is smaller.

@HalvorHaugan HalvorHaugan merged commit 074c8da into main Oct 8, 2024
5 checks passed
@HalvorHaugan HalvorHaugan deleted the list-large branch October 8, 2024 09:30
@github-actions github-actions bot mentioned this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants