Feature/combobox show add new value while autocompleting #3225
Conversation
…lue, so it is displayed when autocompleting words
🦋 Changeset detectedLatest commit: 79e896b The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Storybook demo7ef6b604c | 91 komponenter | 144 stories |
|
Side note: Haven't thought about this before, but doesn't the gray background of the "add" option look somewhat similar to the focus/hover state of the "normal" options? I understand that we want to distinguish it, though. I also think it's a bit weird that the focus/hover states are so different. |
🧠 Think it makes sense to just treat it like any other option visually |
…rch matches. This only seemed to be a problem in testing library, so we should be able to remove this if they fix this in their calculation of accessible name.
Talked to Sjur about this, and he agrees that we should adjust this design. Sounds like maybe he talked to some of you about it as well? We agreed that it can happen outside of this PR, though. |
|
Hmm... I think you should take a look at chromatic. |
it-vegard
deleted the
feature/combobox-show-addNewValue-while-autocompleting
branch
Description
Enable option to add a new value while autocompleting (match searchText instead of value).
Also highlight matches in FilteredOptions to better explain why the options is shown.
Component Checklist 📝
@navikt/core/css/config/_mappings.js)@navikt/core/css/tokens.json)@navikt/aksel-stylelint/src/deprecations.ts)@navikt/core/react/src/index.tsand@navikt/core/react/package.json)@navikt/core/css/index.css)<Component>: <gitmoji?> <Text>.E.g. "Button: ✨ Add feature xyz.")