Stylelint v16 update #3250
Merged
Stylelint v16 update #3250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 596ad7e The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Storybook demo5ea14a9e3 | 91 komponenter | 144 stories |
@navikt/core/css/modal.css
Outdated
| right: 0; | ||
| bottom: 0; | ||
| left: 0; | ||
| inset: 0; |
There was a problem hiding this comment.
caniuse claims 1.3% in Norway use an iOS device that doesn't support inset 🤔 https://caniuse.com/mdn-css_properties_inset
Not sure where we should draw the line. I see we have used it other places though, so I guess we have "ripped of the band-aid" already?
There was a problem hiding this comment.
Since this is only applied when using the polyfill, one could assume that inset might not be supported.. So reverted the change 👍
Co-authored-by: Halvor Haugan <[email protected]>
HalvorHaugan
previously approved these changes
Oct 18, 2024
HalvorHaugan
approved these changes
Oct 21, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrated to Styleint v16 🎉
Seems like our plugin still works as expected 🎉
Biggest changes:
Component Checklist 📝
@navikt/core/css/config/_mappings.js)@navikt/core/css/tokens.json)@navikt/aksel-stylelint/src/deprecations.ts)@navikt/core/react/src/index.tsand@navikt/core/react/package.json)@navikt/core/css/index.css)<Component>: <gitmoji?> <Text>.E.g. "Button: ✨ Add feature xyz.")