Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox: Remove redundant attribute aria-checked #3274

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

HalvorHaugan
Copy link
Contributor

Description

https://nav-it.slack.com/archives/C7NE7A8UF/p1729665701404419
The HTML validator doesn't like using aria-checked on <input type="checkbox">. Afaics it works fine without.

Component Checklist 📝

  • JSDoc
  • Examples
  • Documentation
  • Storybook
  • Style mappings (@navikt/core/css/config/_mappings.js)
  • Component tokens (@navikt/core/css/tokens.json)
  • CSS class deprecations (@navikt/aksel-stylelint/src/deprecations.ts)
  • Exports (@navikt/core/react/src/index.ts and @navikt/core/react/package.json)
  • New component? CSS import (@navikt/core/css/index.css)
  • Breaking change? Update migration guide. Consider codemod.
  • Changeset (Format: <Component>: <gitmoji?> <Text>. E.g. "Button: ✨ Add feature xyz.")

Copy link

changeset-bot bot commented Oct 23, 2024

🦋 Changeset detected

Latest commit: 43182cd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/ds-react Patch
@navikt/ds-css Patch
@navikt/ds-tokens Patch
@navikt/ds-tailwind Patch
@navikt/aksel-icons Patch
@navikt/aksel Patch
@navikt/aksel-stylelint Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Storybook demo

17704367e | 91 komponenter | 144 stories

Copy link
Contributor

@it-vegard it-vegard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine in VoiceOver in Chrome, Firefox and Safari. 🚀

@HalvorHaugan HalvorHaugan merged commit 9711de9 into main Oct 23, 2024
4 checks passed
@HalvorHaugan HalvorHaugan deleted the cb-aria-checked branch October 23, 2024 11:48
@github-actions github-actions bot mentioned this pull request Oct 23, 2024
akgagnat added a commit to navikt/skjemabygging-formio that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants