Pagination: More precise type for renderItem #3275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e67fd5d The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
HalvorHaugan
commented
Oct 23, 2024
| @@ -8,6 +8,17 @@ import PaginationItem, { | |||
| PaginationItemType, | |||
| } from "./PaginationItem"; | |||
|
|
|||
| interface RenderItemProps | |||
There was a problem hiding this comment.
Should we export this?
There was a problem hiding this comment.
Only if it makes sense to use / pass down from outside 🤔
Man får jo typen inn når man bruker renderItem prop (forresten, visste ikke at vi hadde renderItem før nå 😅. Lagde nettopp min egen utrolig stygge pagination med box og borderWidth 😎). Det er kanskje ikke så mange brukere av denne propen? (er nice i de tilfellene man vil ha den)
Storybook demo22f505170 | 91 komponenter | 144 stories |
JulianNymark
approved these changes
Oct 28, 2024
KenAJoh
approved these changes
Oct 30, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The type for the props in
renderItemshould reflect what we actually send to it. This is in theory a breaking change, but seems like no one is using this prop anyways. And if anyone were, there's no reason why they would try to use any of the props that are now removed from the type (since they were not there in the first place).Component Checklist 📝
@navikt/core/css/config/_mappings.js)@navikt/core/css/tokens.json)@navikt/aksel-stylelint/src/deprecations.ts)@navikt/core/react/src/index.tsand@navikt/core/react/package.json)@navikt/core/css/index.css)<Component>: <gitmoji?> <Text>.E.g. "Button: ✨ Add feature xyz.")