Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Darkside] ReadMore CSS update #3372

Merged
merged 16 commits into from
Nov 25, 2024
Merged

[Darkside] ReadMore CSS update #3372

merged 16 commits into from
Nov 25, 2024

Conversation

KenAJoh
Copy link
Collaborator

@KenAJoh KenAJoh commented Nov 14, 2024

Description

@KenAJoh KenAJoh self-assigned this Nov 14, 2024
@KenAJoh KenAJoh requested review from a team as code owners November 14, 2024 15:09
Copy link

changeset-bot bot commented Nov 14, 2024

🦋 Changeset detected

Latest commit: ac00991

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/ds-react Minor
@navikt/ds-css Minor
@navikt/aksel-stylelint Minor
@navikt/aksel Minor
@navikt/ds-tokens Minor
@navikt/ds-tailwind Minor
@navikt/aksel-icons Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 14, 2024

Storybook demo / Chromatic

📝 Endringer til review: 1

36002af5e | 91 komponenter | 135 stories

@navikt/core/react/src/provider/theme/AkselTheme.tsx Outdated Show resolved Hide resolved
@navikt/core/react/src/provider/theme/AkselTheme.tsx Outdated Show resolved Hide resolved
<div
ref={ref}
className={cl("navds-theme", className, theme)}
data-background={hasBackground}
data-volume={volume}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the current implementation no, but it's nice to see the current state in the DOM when testing.

@KenAJoh KenAJoh merged commit 641276b into main Nov 25, 2024
3 checks passed
@KenAJoh KenAJoh deleted the darkside-readmore-css branch November 25, 2024 11:27
@github-actions github-actions bot mentioned this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants