Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Modal now handles cases where it was opened with show() #3407

Merged
merged 5 commits into from
Nov 26, 2024
+10 −0
Merged

🐛 Modal now handles cases where it was opened with show() #3407

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
778b6b2
:bug: Modal now handles cases where it was opened with `show()`
KenAJoh Nov 26, 2024
1a38704
Update .changeset/sweet-birds-care.md
KenAJoh Nov 26, 2024
a50d065
:bug: Add bottom unset to polyfilled modal
KenAJoh Nov 26, 2024
0510986
Update @navikt/core/css/modal.css
KenAJoh Nov 26, 2024
d81ddd0
Update .changeset/sweet-birds-care.md
KenAJoh Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/sweet-birds-care.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@navikt/ds-css": patch
---

Modal: Now shows up while screensharing with Vergic"
KenAJoh marked this conversation as resolved.
Show resolved Hide resolved
5 changes: 5 additions & 0 deletions @navikt/core/css/modal.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@
max-height: 100%;
max-width: 100%;
color: var(--a-text-default);

/* In case Modal is opened with `show()`, in eg. Vergic screensharing */
inset: 0;
z-index: 9999;
}

.navds-modal[open] {
Expand All @@ -24,6 +28,7 @@

.navds-modal--polyfilled {
top: 50%;
bottom: unset; /* Overrides inset: 0 from .navds-modal */
transform: translate(0, -50%);

/* From polyfill (dialog-polyfill/dist/dialog-polyfill.css): */
Expand Down
Loading