-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate GuidePanel and HelpText, remove text from InternalHeader. #3424
Conversation
🦋 Changeset detectedLatest commit: c2ca745 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Storybook demofa56ca9bd | 91 komponenter | 135 stories |
illustrationLabel: "Illustration of advisor", | ||
}, | ||
HelpText: { | ||
title: "Help", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just "Help" seems a little ambiguous if not used inside a specific context. I see Skatteetaten.no also use "help", so might not be an actual issue and we have used this for 6+ years now without issue.
Could any of these work?
- Help description
- Help text
- Help content
- Additional information
- Supplemental information
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. I think I'll go for an "information" variant. What do you think about just "More information"? "Additional" feels like a more "complex" word than necessary, if that makes sense. Or is there a difference between these words that's relevant here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"More information" works 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 🚢 🇮🇹
Component Checklist 📝
@navikt/core/css/config/_mappings.js
)@navikt/core/css/tokens.json
)@navikt/aksel-stylelint/src/deprecations.ts
)@navikt/core/react/src/index.ts
and@navikt/core/react/package.json
)@navikt/core/css/index.css
)<Component>: <gitmoji?> <Text>.
E.g. "Button: ✨ Add feature xyz.")