Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate GuidePanel and HelpText, remove text from InternalHeader. #3424

Merged
merged 5 commits into from
Dec 4, 2024

Conversation

HalvorHaugan
Copy link
Contributor

@HalvorHaugan HalvorHaugan commented Dec 2, 2024

Component Checklist 📝

  • JSDoc
  • Examples
  • Documentation / Decision Records
  • Storybook
  • Style mappings (@navikt/core/css/config/_mappings.js)
  • Component tokens (@navikt/core/css/tokens.json)
  • CSS class deprecations (@navikt/aksel-stylelint/src/deprecations.ts)
  • Exports (@navikt/core/react/src/index.ts and @navikt/core/react/package.json)
  • New component? CSS import (@navikt/core/css/index.css)
  • Breaking change? Update migration guide. Consider codemod.
  • Changeset (Format: <Component>: <gitmoji?> <Text>. E.g. "Button: ✨ Add feature xyz.")

Copy link

changeset-bot bot commented Dec 2, 2024

🦋 Changeset detected

Latest commit: c2ca745

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/ds-react Patch
@navikt/ds-css Patch
@navikt/ds-tokens Patch
@navikt/ds-tailwind Patch
@navikt/aksel-icons Patch
@navikt/aksel Patch
@navikt/aksel-stylelint Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Storybook demo

fa56ca9bd | 91 komponenter | 135 stories

.changeset/fair-countries-admire.md Outdated Show resolved Hide resolved
illustrationLabel: "Illustration of advisor",
},
HelpText: {
title: "Help",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just "Help" seems a little ambiguous if not used inside a specific context. I see Skatteetaten.no also use "help", so might not be an actual issue and we have used this for 6+ years now without issue.
Could any of these work?

  • Help description
  • Help text
  • Help content
  • Additional information
  • Supplemental information

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I think I'll go for an "information" variant. What do you think about just "More information"? "Additional" feels like a more "complex" word than necessary, if that makes sense. Or is there a difference between these words that's relevant here?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"More information" works 👍

Copy link
Collaborator

@KenAJoh KenAJoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 🚢 🇮🇹

@HalvorHaugan HalvorHaugan merged commit bae136f into main Dec 4, 2024
4 checks passed
@HalvorHaugan HalvorHaugan deleted the guidepanel-helptext-header-i18n branch December 4, 2024 09:29
@github-actions github-actions bot mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants