[Combobox] Only open dropdown onClick, not onFocus. #3440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wn list and hide error
🦋 Changeset detectedLatest commit: e80e933 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Storybook demoa46619918 | 91 komponenter | 135 stories |
|
The list no longer closes after selecting an option in single select mode. |
@HalvorHaugan Should be fixed now 🤞 |
HalvorHaugan
previously approved these changes
Dec 18, 2024
Comment on lines
+62
to
+64
| if (inputProps.disabled || readOnly) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
I don't think we technically need to check this, but it doesn't hurt either.
.changeset/forty-rules-ring.md
Outdated
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@navikt/ds-react": minor | |||
There was a problem hiding this comment.
Would patch be more correct here? 🤔 Not sure myself.
KenAJoh
commented
Dec 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This solves the issue where programmatic focus would open dropdown. This in turn would hide any error for the field in the cases that would be relevant.
Resolves #3437
The fix itself almost seems too simple to just "work", so will need some help reviewing edgecases that might have been forgotten. I didn't actually need to check for readOnly or disabled-state for it to work, but exit early anyways just incase we change that in the future.
Component Checklist 📝
@navikt/core/css/config/_mappings.js)@navikt/core/css/tokens.json)@navikt/aksel-stylelint/src/deprecations.ts)@navikt/core/react/src/index.tsand@navikt/core/react/package.json)@navikt/core/css/index.css)<Component>: <gitmoji?> <Text>.E.g. "Button: ✨ Add feature xyz.")