[Darkside] P 1/2 ♻️ Updated default scale to replace neutral-scale
#3487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 🚚 Migrated to new space-token * 📝 Add docs for temp spacing * 🐛 Add missing token-prefix to docs * 🐛 Remove old tests
|
Storybook demo / Chromatic📝 Changes to review: 2a8d8156c1 | 91 components | 135 stories |
KenAJoh
changed the title
default scale to replace neutral-scaledefault scale to replace neutral-scale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed before x-mas, we want to avoid having both the neutral and default-scale server overlapping cases. To handle this, we remove the "semantic"-role tokens for "neutral" and moved them over to neutral. Neutral is now only a "global"-color to be consumed by other semantic roles, not a role itself.
NOTE: This PR just handles the changes, a new PR based on this one will update all use of the semantic role "neutral" (100+ instances) in the new darkside css.
Component Checklist 📝
@navikt/core/css/config/_mappings.js)@navikt/core/css/tokens.json)@navikt/aksel-stylelint/src/deprecations.ts)@navikt/core/react/src/index.tsand@navikt/core/react/package.json)@navikt/core/css/index.css)<Component>: <gitmoji?> <Text>.E.g. "Button: ✨ Add feature xyz.")