Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fiks henting av tags i prod workflow (v2) #803

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Conversation

bjerga
Copy link
Contributor

@bjerga bjerga commented Dec 9, 2024

Et nytt forsøk på å fikse prod workflow. Siste feil skyldes at fetch-tags: true ikke fungerer med en workflow som trigges av en tag, slik vår gjør.

Se https://github.com/navikt/helsearbeidsgiver-inntektsmelding/actions/runs/12235255860/job/34126166060#step:2:58 for feilende workflow.

Se actions/checkout#1467 for Github issue for checkout-actionen.

@bjerga bjerga requested a review from a team as a code owner December 9, 2024 13:41

# We fetch tags here because 'fetch-tags'-option on checkout-action doesn't work on release
- name: Fetch tags
run: git fetch --depth=1 --tags --quiet
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

holder det med fetch depth=1 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jess, det gjelder bare for commitene, ikke for tagene.

Copy link
Contributor

@b162214 b162214 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏎️

@bjerga bjerga merged commit 497d961 into main Dec 9, 2024
17 checks passed
@bjerga bjerga deleted the fiks-tags-prod-workflow-v2 branch December 9, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants