Concatenation of announcements now working #18
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up to now the concatenation of turn announcements isn't implemented correctly.
Currently two announcements are only connected if the announcements are such close in a timely manner that they tend to get overlapped. In practice this hardly ever occurs.
In my view this is not the idea of concatenating turns. They shall be concatenated if the turns are close in a distance manner.
Hence, for me the criteria shall be like this:
Here is an example:
1.: "turn right soon"
2.: "in 250 meters turn right into the Riedlstraße, then turn left into the Marxstraße"
3.: "turn right into the Riedlstraße now, then turn left into the Marxstraße"
4.: ("turn left into the Marxstraße soon" will be suppressed, as well as "follow the road for the next xx meters")
5.: "in 250 meters turn left into the Marxstraße" -> This may be suppressed, if the announcement no. 6 would come a few meters later. Navit would interrupt itself otherwise.
6.: "turn left into the Marxstraße now"
In such situations, in which many turns come close after the other this behavior sounds much less mechanic and for me it saves a bunch of nerves of the users because of annoying announcements.
Have fun!