Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concatenation of announcements now working #18

Merged
merged 1 commit into from
Sep 11, 2015
Merged

Concatenation of announcements now working #18

merged 1 commit into from
Sep 11, 2015

Conversation

Robotaxi
Copy link
Contributor

Up to now the concatenation of turn announcements isn't implemented correctly.

Currently two announcements are only connected if the announcements are such close in a timely manner that they tend to get overlapped. In practice this hardly ever occurs.
In my view this is not the idea of concatenating turns. They shall be concatenated if the turns are close in a distance manner.

Hence, for me the criteria shall be like this:

  • If two turns have a distance to each other that is less than the "level 2"-distance configured for the specific route item, (which stands for the "soon"-announcement), they shall be concatenated.
  • The "soon" announcement for the second turn shall be suppressed in that case.
  • Any announcement for the second turn from that concatenation down to "level 1" shall be suppressed, if (and only if) it would come too close to the preceding one.

Here is an example:
1.: "turn right soon"
2.: "in 250 meters turn right into the Riedlstraße, then turn left into the Marxstraße"
3.: "turn right into the Riedlstraße now, then turn left into the Marxstraße"
4.: ("turn left into the Marxstraße soon" will be suppressed, as well as "follow the road for the next xx meters")
5.: "in 250 meters turn left into the Marxstraße" -> This may be suppressed, if the announcement no. 6 would come a few meters later. Navit would interrupt itself otherwise.
6.: "turn left into the Marxstraße now"

In such situations, in which many turns come close after the other this behavior sounds much less mechanic and for me it saves a bunch of nerves of the users because of annoying announcements.
Have fun!

@pgrandin
Copy link
Contributor

Robotaxi, I'd be really happy to merge this PR, but can you please look at solving the conflict?

Thanks!

@Robotaxi Robotaxi merged commit 20e32a0 into trunk Sep 11, 2015
@pgrandin
Copy link
Contributor

Thanks Robotaxi!
Just a heads-up for the next time : let's avoid merging translation directly in the trunk as it will mess up our launchpad workflow.

Great job otherwise!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants