fix:gtk:fixed missing imperial units in the GTK ui. #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: navit/gui/gtk/gui_gtk_statusbar.c
|
The fix is on branch fix_gtk_imperial_use |
constants in navigation.h instead. modified: navit/gui/gtk/gui_gtk_statusbar.c
commit. modified: navit/gui/gtk/gui_gtk_statusbar.c
|
Thanks @charlescurley for fixing that! |
jkoan
added a commit
to jkoan/navit
that referenced
this pull request
Nov 1, 2017
# Das ist die erste Commit-Beschreibung: Fix:android: Fixed forced colors in layout to have android auto adaption # Das ist Commit-Beschreibung #2: Always build 'release' package for android # Das ist Commit-Beschreibung #3: Fix:android:Ensures that we capture all build errors # Das ist Commit-Beschreibung #4: Revert "Fix:android:Ensures that we capture all build errors" This reverts commit 13bc8d0. # Das ist Commit-Beschreibung #5: Revert "Always build 'release' package for android" This reverts commit 31c9535. # Das ist Commit-Beschreibung #6: Refactor:route:Add documentation Signed-off-by: mvglasow <michael -at- vonglasow.com> # Das ist Commit-Beschreibung #7: Refactor:route:Add documentation Signed-off-by: mvglasow <michael -at- vonglasow.com> # Das ist Commit-Beschreibung #8: Refactor:route:Add documentation Signed-off-by: mvglasow <michael -at- vonglasow.com> # Das ist Commit-Beschreibung #9: update:doc:Build doxygen doc and push the result to a gh-pages branch (navit-gps#354) Result visible at http://navit-gps.github.io/navit/ # Das ist Commit-Beschreibung #10: Update:i18n:Updated Čeština translation from launchpad (navit-gps#351) # Das ist Commit-Beschreibung #11: Update:i18n:Updated Spanish translation from launchpad (navit-gps#352) # Das ist Commit-Beschreibung #12: Update:i18n:Updated French (fr) translation from launchpad (navit-gps#353) # Das ist Commit-Beschreibung #13: fix:android:Add workaround for android platform tools (navit-gps#357) # Das ist Commit-Beschreibung #14: add:icon:diving # Das ist Commit-Beschreibung #15: fix:gtk:fixed missing imperial units in the GTK ui. (navit-gps#359)
jkoan
pushed a commit
to jkoan/navit
that referenced
this pull request
Nov 1, 2017
jkoan
pushed a commit
to jkoan/navit
that referenced
this pull request
Nov 6, 2017
jkoan
pushed a commit
to jkoan/navit
that referenced
this pull request
Nov 23, 2017
hoehnp
pushed a commit
to hoehnp/navit
that referenced
this pull request
Jan 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The status bar under GTK was only showing metric units. So I coded up a fix.
I tested as follows:
Initialized the local variable imperial to true. Had imperial set to one in my navit.xml. Got imperial measures, as expected.
Changed the local variable initialization to false. Recompiled and ran. Got imperial, as expected. This indicates that the function collected it as expected.
Changed the attribute in navit.xml to 0. Ran again. Got metric units as expected.