Refactor Long Quote Block in LiveResource #659
Merged
+830
−860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Flo0807 I changed a few internal function with theoretically could be used from the outside. The chance is relatively small... should we add it to the upgrade guide? |
I'd say yes, but we don't have to explain every change in detail. @pehbehbeh |
Flo0807
requested changes
Nov 8, 2024
Co-authored-by: Florian Arens <[email protected]>
Flo0807
reviewed
Nov 28, 2024
|
|
||
| {:noreply, socket} | ||
| end | ||
| def handle_event(event, params, socket), do: LiveResource.handle_event(event, params, socket) |
There was a problem hiding this comment.
@pehbehbeh this will catch all events, and users are no longer able to define own handle_event functions in their LiveResources because all events are delegated toBackpex.LiveResource. Same with handle_info etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://hexdocs.pm/credo/Credo.Check.Refactor.LongQuoteBlocks.html
Backpex.LiveResourceBackpex.LiveResource.schema/0function; see 709bff8Backpex.LiveResource.can?/4helper; see 9bdd735 and a474210get_filter_optionsfunction; see 2a43e79