Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return an Err on shape mismatch instead of panic #77

Merged
merged 1 commit into from
May 9, 2021

Conversation

krlohnes
Copy link
Contributor

@krlohnes krlohnes commented May 7, 2021

This way we let the user of the library decide how to handle the issue.

This is a fix for #76

This way we let the user of the library decide how to handle the issue.
@codecov-commenter
Copy link

Codecov Report

Merging #77 (788bd3a) into master (1948683) will increase coverage by 0.26%.
The diff coverage is 52.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
+ Coverage   14.58%   14.85%   +0.26%     
==========================================
  Files          18       19       +1     
  Lines         960     1212     +252     
==========================================
+ Hits          140      180      +40     
- Misses        820     1032     +212     
Impacted Files Coverage Δ
onnxruntime/src/lib.rs 42.55% <0.00%> (+5.20%) ⬆️
onnxruntime/src/session.rs 0.00% <0.00%> (ø)
onnxruntime/src/tensor/ort_tensor.rs 79.16% <75.47%> (-3.19%) ⬇️
onnxruntime/src/error.rs 62.50% <100.00%> (+5.35%) ⬆️
onnxruntime/src/download.rs 0.00% <0.00%> (ø)
...runtime-sys/src/generated/macos/x86_64/bindings.rs 0.00% <0.00%> (ø)
...untime/src/download/vision/image_classification.rs 0.00% <0.00%> (ø)
...ime/src/download/language/machine_comprehension.rs 0.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b5fcd3...788bd3a. Read the comment docs.

@nbigaouette nbigaouette merged commit 8ee61fb into nbigaouette:master May 9, 2021
@nbigaouette
Copy link
Owner

Thank you!

@krlohnes krlohnes deleted the fix_shape_panic branch July 6, 2021 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants