Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure files are sorted when parsing #57

Merged
merged 2 commits into from
Jun 28, 2021
Merged

Make sure files are sorted when parsing #57

merged 2 commits into from
Jun 28, 2021

Conversation

mgrover1
Copy link
Contributor

@mgrover1 mgrover1 commented Jun 24, 2021 •
edited
Loading

Addresses #56
Wraps file read in with sorted to make sure files are sorted before parsing

@mgrover1 mgrover1 requested a review from andersy005 June 24, 2021 20:23
andersy005
andersy005 reviewed Jun 24, 2021
View reviewed changes
Copy link
Member

@andersy005 andersy005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about sorting the final list instead?

https://github.com/NCAR/ecgtools/blob/bc29591bb35e2092f25767817aae3090aba7254e/ecgtools/builder.py#L128

@mgrover1 mgrover1 requested a review from andersy005 June 28, 2021 18:18
andersy005
andersy005 approved these changes Jun 28, 2021
View reviewed changes
Copy link
Member

@andersy005 andersy005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, @mgrover1! Merging this shortly

@andersy005 andersy005 merged commit 71f5e60 into ncar-xdev:main Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andersy005 andersy005 andersy005 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgrover1 @andersy005