fix(ui): fix state management on unmounted component

ncarlier · Apr 24, 2020 · a67abce · a67abce
1 parent 4c33601
commit a67abce
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/ui/src/articles/components/MarkAsButton.tsx b/ui/src/articles/components/MarkAsButton.tsx
@@ -31,6 +31,7 @@ export default (props: Props) => {
           variables: { id: article.id, status },
           update: updateCacheAfterUpdate,
         })
+        // TODO we should not update state if mutation trigger an unmount on this element
         if (!floating) setLoading(false)
         if (onSuccess) onSuccess(article)
       } catch (err) {

diff --git a/ui/src/articles/components/NewArticlesAvailable.tsx b/ui/src/articles/components/NewArticlesAvailable.tsx
@@ -35,11 +35,8 @@ export default ({ current, category, refresh }: Props) => {
 
   const reload = useCallback(async () => {
     setLoading(true)
-    try {
-      await refresh()
-    } finally {
-      setLoading(false)
-    }
+    await refresh()
+    // No need to reset loading state because this componemt will be unmounted
   }, [refresh])
 
   const getNbArticlesToRead = useCallback(