Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate user entry of URI in the OWL properties #57

Closed
alexskr opened this issue Aug 4, 2017 · 5 comments
Closed

Validate user entry of URI in the OWL properties #57

alexskr opened this issue Aug 4, 2017 · 5 comments

Comments

@alexskr
Copy link
Member

alexskr commented Aug 4, 2017

URI do not get encoded properly (or validated) when users edit OWL ontology properties.
For example, users mistakenly put their names instead of URI into preferred name property. This data gets saved into triple store in the following manner:

<http://data.bioontology.org/ontologies/ACRONYM/submissions/1> <http://data.bioontology.org/metadata/authorProperty> <local:Firstname\u0020\Lastname> .
<http://data.bioontology.org/ontologies/ACRONYM/submissions/5> <http://data.bioontology.org/metadata/prefLabelProperty> <local:My Ontology Name> .

This creates problems for us when metadata graph is imported back into the triple store:

URI http://data.bioontology.org/metadata/OntologySubmission:8009 raptor error - Turtle URI error - illegal Unicode escape \u0020 in URI.

@alexskr alexskr changed the title URI encoding issue for OWL properties Validate user entry of URI in the OWL properties Nov 23, 2021
@alexskr
Copy link
Member Author

alexskr commented Nov 23, 2021

API and/or UI need to validate the user's input to make sure a valid URI is entered for those fields.
Users seem to be confused about this over a number of years so this submission form should benefit from a clear instruction that entries have to be in the URI format

@alexskr
Copy link
Member Author

alexskr commented Sep 6, 2023

fixed by ncbo/goo#138 and ncbo/goo#139

image

@syphax-bouazzouni
Copy link
Contributor

syphax-bouazzouni commented Sep 6, 2023

Always great to see, old issues being fixed.
The error display is fixed locally in our new UI (see ontoportal-lirmm#320). But will take us some time to do a PR for you.
But a temporary solution can be by updating these lines https://github.com/ncbo/bioportal_web_ui/blob/master/app/views/submissions/_form.html.haml#L3-L8 like so https://github.com/ontoportal-lirmm/bioportal_web_ui/blob/master/app/views/submissions/_form.html.haml#L22-L31

@alexskr
Copy link
Member Author

alexskr commented Sep 7, 2023

@syphax-bouazzouni Thanks for the tip!

alexskr added a commit that referenced this issue Sep 7, 2023
fix formatting issue with displaying errors. #57
@alexskr
Copy link
Member Author

alexskr commented Sep 7, 2023

looks much better
image

@alexskr alexskr closed this as completed Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants