-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Multilingual support - Add request language middleware #148
Feature: Multilingual support - Add request language middleware #148
Conversation
Merge develop -> master, release 5.29.1
…parameter "lang" or "language"
1d35da7
to
84f079e
Compare
88973e9
to
2a675bb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #148 +/- ##
===========================================
+ Coverage 73.13% 73.28% +0.15%
===========================================
Files 52 53 +1
Lines 2903 2916 +13
===========================================
+ Hits 2123 2137 +14
+ Misses 780 779 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I understand why the Solr schema was added to the ontologies_api project in this PR; it eliminates the need to keep the ontoportal/solr-ut image synchronized when schema changes occur. A more elegant solution could be implemented to maintain schema synchronization between ontologies_api and ontologies_linked_data, but this requirement will disappear after the schemaless Solr feature is implemented. At that point, the Solr configuration could be removed from ontologies_api. |
a208415
into
ncbo:feature/multilingual-support-add-language-request-middleware
Require
Context
This PR adds a middleware request_lang that will save for each request the parameter
lang
orlanguage
if set, as a global variable that will filter the values by it.In addition, it updates the search helper, to add the selected language as a suffix of the SOLR requests, to search by the selected language only.
Changes