Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify and add unit tests for the purl method in LinkedData::Client::Models::Class #29

Merged
merged 11 commits into from
Jul 14, 2023

Conversation

jvendetti
Copy link
Member

  • Modifies the purl method to check class IDs for a PURL host, rather than the string 'purl' (see this comment).
  • Makes the PURL host configurable, and sets a default value
  • Adds several unit tests for the purl method
  • Configures PURL host and prefix values in config.test.rb for the purposes of unit text execution
  • Adds a development dependency on faraday-follow_redirects for testing proper PURL resolution
  • Moves the gem version specifier to a module
  • Fixes some RuboCop warnings

@jvendetti jvendetti self-assigned this Jul 14, 2023
@jvendetti jvendetti merged commit 640e392 into master Jul 14, 2023
@jvendetti jvendetti deleted the bugfix/broken-purls/28 branch January 8, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant