86: pre-commit runs on all files #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidanjgriffiths
requested changes
Nov 10, 2023
There was a problem hiding this comment.
Looks good @John-Sharples, I've left a few suggestions.
Another suggestion would be to make the pre-commit config either use the local dev env or using a pre-commit env and making sure to keep dev and pre-commit deps at the same version. The former works quite well in my experience but we will need to add isort to the dev deps in pyproject.toml
Co-authored-by: Aidan Griffiths <[email protected]> Signed-off-by: tennlee <[email protected]>
Co-authored-by: Aidan Griffiths <[email protected]> Signed-off-by: tennlee <[email protected]>
Co-authored-by: Aidan Griffiths <[email protected]> Signed-off-by: tennlee <[email protected]>
Signed-off-by: tennlee <[email protected]>
tennlee
added a commit
that referenced
this pull request
Jan 19, 2024
* 86: pre-commit runs on all files * 86: run pre-commit on push * 86: update pylint version * 86: pylint version and scoring >9.8 * Update .github/workflows/run-pre-commit.yml Co-authored-by: Aidan Griffiths <[email protected]> Signed-off-by: tennlee <[email protected]> * Update .github/workflows/run-pre-commit.yml Co-authored-by: Aidan Griffiths <[email protected]> Signed-off-by: tennlee <[email protected]> * Update docs/conf.py Co-authored-by: Aidan Griffiths <[email protected]> Signed-off-by: tennlee <[email protected]> --------- Signed-off-by: tennlee <[email protected]> Co-authored-by: tennlee <[email protected]> Co-authored-by: Aidan Griffiths <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR change pre-commit workflow to run on all files, fixing issue where no-files were scanned in PR. The facilitate this change:
Closes #86