Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added isotonic regression to docs #112

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

nicholasloveday
Copy link
Collaborator

@nicholasloveday nicholasloveday commented Nov 16, 2023

No description provided.

@nicholasloveday nicholasloveday linked an issue Nov 16, 2023 that may be closed by this pull request
Copy link
Collaborator

@reza-armuei reza-armuei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nicholasloveday, Thanks for adding isotonic regression to the docs. Changes are fine. There are two mypy errors (I faced exactly the same errors). @tennlee, Do you know how we can address these errors?

@nicholasloveday nicholasloveday force-pushed the 111-add-isotonic-regression-to-docs branch from 9652e81 to d38e286 Compare February 16, 2024 04:37
@nicholasloveday nicholasloveday marked this pull request as ready for review February 16, 2024 04:37
@nicholasloveday nicholasloveday force-pushed the 111-add-isotonic-regression-to-docs branch from d38e286 to a757f21 Compare February 16, 2024 04:39
@nicholasloveday
Copy link
Collaborator Author

@tennlee I've updated this old pull request, so now some of the docs should be more up to date.

@nicholasloveday nicholasloveday force-pushed the 111-add-isotonic-regression-to-docs branch from a757f21 to c2ca4ed Compare February 16, 2024 04:40
@tennlee tennlee merged commit 93995f3 into develop Feb 21, 2024
6 checks passed
@tennlee tennlee deleted the 111-add-isotonic-regression-to-docs branch February 21, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add isotonic regression to docs
3 participants