feat: add proportion exceeding wrapper for flip flop index #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidanjgriffiths
force-pushed
the
119-add-proportion-exceeding-wrapper-for-flip-flop-index
branch
2 times, most recently
from
4125074 to
dece4bb
Compare
|
@tennlee and @nicholasloveday this PR is ready for review. On to #106... |
aidanjgriffiths
force-pushed
the
119-add-proportion-exceeding-wrapper-for-flip-flop-index
branch
from
dece4bb to
59a04ed
Compare
nicholasloveday
requested changes
Dec 6, 2023
aidanjgriffiths
force-pushed
the
119-add-proportion-exceeding-wrapper-for-flip-flop-index
branch
2 times, most recently
from
410436b to
a1a2e0f
Compare
|
@nicholasloveday take another look, I've addressed your comments, mainly around the preserve and reduce dim parameters you requested. |
nicholasloveday
requested changes
Jan 16, 2024
There was a problem hiding this comment.
Thanks for the updates @aidanjgriffiths . A few suggestions
nicholasloveday
force-pushed
the
119-add-proportion-exceeding-wrapper-for-flip-flop-index
branch
from
16f293d to
87bf7fd
Compare
tennlee
pushed a commit
that referenced
this pull request
Feb 13, 2024
* feat: add proportion exceeding wrapper for flip flop index * minor updates to flipflop proportion exceeding --------- Co-authored-by: Nicholas Loveday <[email protected]>
tennlee
pushed a commit
that referenced
this pull request
Feb 13, 2024
* feat: add proportion exceeding wrapper for flip flop index * minor updates to flipflop proportion exceeding --------- Co-authored-by: Nicholas Loveday <[email protected]>
tennlee
added a commit
that referenced
this pull request
Feb 14, 2024
* feat: new flip flop tutorial notebook * Updated markdown * Improved citation syntax somewhat with newlines and italics to demarcate things * Review of MAE tutorial (#116) * First review and extension Co-authored-by: Tennessee Leeuwenburg <[email protected]> * Update contributing.md Signed-off-by: tennlee <[email protected]> * feat: add proportion exceeding wrapper for flip flop index (#120) * feat: add proportion exceeding wrapper for flip flop index * minor updates to flipflop proportion exceeding --------- Co-authored-by: Nicholas Loveday <[email protected]> * MSE tutorial reviewed by Deryn. * RMSE tutorial reviewed by Deryn * Tidy of MAE, MSE and RMSE tutorials (#136) * Split first cell into two * Added a semi-colon to a markdown cell * Removed one unused variable * Added a plot to flip-flop tutorial * Updated graph labels --------- Signed-off-by: tennlee <[email protected]> Co-authored-by: aidanjgriffiths <[email protected]> Co-authored-by: Tennessee Leeuwenburg <[email protected]> Co-authored-by: tennlee <[email protected]> Co-authored-by: Aidan Griffiths <[email protected]> Co-authored-by: Nicholas Loveday <[email protected]>
tennlee
deleted the
119-add-proportion-exceeding-wrapper-for-flip-flop-index
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding proportion exceeding for future papers and notebook demos.