-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add roc curve #72
add roc curve #72
Conversation
This is still work in progress.
|
It also may need to be updated if #71 is merged in first. |
16115d8
to
e3e6d0d
Compare
d17e987
to
6d09906
Compare
Since this is a large pull request, here is the suggested order that I think would be good to tackle the code review.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @nicholasloveday, there has been some changes to the test directory structure changes in develop
which will resolve in some conflicts from #77. Theres a couple of suggetions in this review but its best if I do a more in depth review once the test suite conflicts are sorted out.
b9e6272
to
e776586
Compare
Thanks @aidanjgriffiths - I've rebased and resolved conflicts. Ready for you to have another look at it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @nicholasloveday!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left a small number of comments but they require addressing. Thanks for this significant contribution.
e776586
to
9e50fcb
Compare
Thanks @tennlee, I've made those changes. |
closes #46