-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/negative predictive value #759
Feature/negative predictive value #759
Conversation
Signed-off-by: arshia <[email protected]>
I haven't looked at your code as yet, but I wanted to provide some extra information. Negative predictive value will also need to be added to the binary categorical score tutorial - specifically, the tutorial includes a list of binary categorical scores included in [Screenshot below is taken from https://scores.readthedocs.io/en/stable/tutorials/Binary_Contingency_Scores.html] Also, I have also just realised that the "success ratio (precision)" entry will also need to be updated to "success ratio (precision, positive predictive value)" - sorry I didn't think of that before. |
…m/arshiaar/scores into feature/negative_predictive_value
name: Arshia Sharma :) |
Thanks Arshia. When I next update the release notes I will include you as "Arshia Sharma (@arshiaar)". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this pull request @arshiaar.
I have some very minor feedback on included.md and the docstring.
I don't have the domain expertise to review the functional code and the tests, so I will leave the review of those to others.
@nicholasloveday FYI, I will re-add you once I've had a chance to review tomorrow, I need to check some things. Feel free to take a look, but also feel free to wait until I've had a look. |
Co-authored-by: Stephanie Chong <[email protected]> Signed-off-by: arshia <[email protected]>
Co-authored-by: Stephanie Chong <[email protected]> Signed-off-by: arshia <[email protected]>
@nicholasloveday okay, feel free to review this now. Sorry! :) |
9b79ba7
to
74790a7
Compare
Thanks for this update @arshiaar . The equation and tests look correct to me. |
In addition to the wikipedia link, can you please add this article/citation to the references: https://www.mdpi.com/1648-9144/57/5/503 . I'll wonder if it would actually be worth adding this to each of: PPV, NPV, sensitivity and specificity. The citation to use is: Monaghan, T. F., Rahman, S. N., Agudelo, C. W., Wein, A. J., Lazar, J. M., Everaert, K., & Dmochowski, R. R. (2021). Foundational Statistical Principles in Medical Research: Sensitivity, Specificity, Positive Predictive Value, and Negative Predictive Value. Medicina, 57(5), 503. https://doi.org/10.3390/medicina57050503 For the other scores that NPV, I would suggest opening a new PR to address those, so that this score can be added sooner than later. |
I will merge this PR as-is, then add the additional reference afterwards. |
Thanks so much for all of this work! :). I have merged this, and also added the Monaghan et al. (2021) reference in to the relevant spots (NPV, PPV, specificity, sensitivity). Here is a link to negative predictive value in the 'latest' (development) build of the docs: https://scores.readthedocs.io/en/latest/api.html#scores.categorical.BasicContingencyManager.negative_predictive_value |
* feat: add ppv function and update alias docstrings * update included.md Co-authored-by: Stephanie Chong <[email protected]> Signed-off-by: arshia <[email protected]> * Update docs/included.md Co-authored-by: Stephanie Chong <[email protected]> Signed-off-by: arshia <[email protected]> --------- Signed-off-by: arshia <[email protected]> Co-authored-by: Arshia Sharma <[email protected]> Co-authored-by: Stephanie Chong <[email protected]>
Issues
Implements issue #750
Docstrings
Documentation