Pin project dependencies during hatch build #760
Conversation
techdragon
force-pushed
the
pin-deps-during-hatch-build
branch
from
eaa8c29 to
d19f7bd
Compare
techdragon
force-pushed
the
pin-deps-during-hatch-build
branch
from
d19f7bd to
daeb147
Compare
|
I have done a diff on the wheel from 1.2.0 as as built by this branch. I have noticed some minor difference we should discuss tomorrow, but essentially this looks good as far as I can tell. So it seems like we could reasonably move forward with this approach. In that spirit, I'm now leaving some fine-grained comments on the PR so this improvement can stand the test of time. |
|
So as far as I can tell this looks great, modulo some minor feedback. Some reflections. I think this means the pyproject.toml for the tagged release in github will vary from what's used to make 'METADATA' in the wheel. So if you were installing from a tagged github release (for some reason) you could get different versions to an sdist or wheel install from pypi. I find it hard to imagine that this would actually matter, but maybe it should be thought about a little. Thank you so much for identifying this approach and putting up this PR, I wouldn't have known how to do this without a lot of painstaking research. |
|
I will also undertake some additional manual testing tomorrow. |
techdragon
force-pushed
the
pin-deps-during-hatch-build
branch
from
850fe97 to
1d5fcc3
Compare
* Add Jetbrains IDE files to .gitignore * Pin dependencies during hatch builds * Add zenodo entry
No description provided.