Contributor guide update

[tennlee]

Hi all,

I would like to update the Contributing Guide to reflect lessons learned from the recent sprints at PyCon AU. I am hoping these updates will better support first-time contributors to scores. Additionally, the guide now makes it clearer how to handle interactions on pull requests generally.

I am proposing adding two sections:

• Creating Your Own Fork of scores for the First Time
• Pull Request Etiquette

I am also proposing updating the following section:

• Workflow for Submitting Pull Requests

@arshiaar, @lbluett , @JinghanFu, @techdragon, @AJTheDataGuy - your feedback would be welcome on whether the updates would have helped you onboard into scores development.

Feedback from @nicholasloveday, @rob-taggart, @reza-armuei, @mareecarroll and @Steph-Chong would be welcome on whether the section on pull request etiquette seems appropriate for first-time and existing contributors alike.

Thanks all.

[tennlee]

Note - we haven't really been following a specific approach to pull request etiquette, but we realised it would be better to adopt an agreed approach going forward

[reza-armuei]

Thanks @tennlee! The given instructions/suggestions in the PR etiquette section sound good and reasonable to me.

[nicholasloveday]

The pull request etiquette section looks look to me! Thanks for adding that.

I have one suggestion on the forking section

[nicholasloveday]

Consider a line to periodically sync your fork

[nicholasloveday]

It could possibly fit into the section just below

[tennlee]

I have added a commit to the PR to add some information on this to the PR workflow. Let me know if that seems sufficient.

[nicholasloveday]

Looks good - In addition it may be good to encourage people to sync their fork before they create a new feature branch to minimise the amount of rebasing etc.

[tennlee]

While that's good advice, I feel like it may be stepping over into a more detailed guide that we don't really have the ability to provide. Ideally, it would be nice to link to some general resource that hopefully already exist out there. Feel free to do some looking around and raise a new PR if you find some good ones.

[tennlee]

Hi everyone. I am going to merge this PR so we can get it into the develop branch and included into the next release. If anyone leaves any more comments here, I will respond to and consider them. Otherwise, feel free to raise a new issue or put up a PR with any specific suggestions that you might have. Everyone should very much feel free to put up PRs at any stage with any kind of suggested improvement.