Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

73 add pre-commit GitHub action #85

Merged
merged 5 commits into from
Oct 25, 2023
Merged

Conversation

John-Sharples
Copy link
Contributor

In this PR:

  • Add a pre-commit github action to run the all pre-commit checks. This means github actions and pre-commit will align.
  • small update to .pre-commit-config.yaml to make black run
  • some isort and black changes to files.

The pre-commit entry point should probably be pre-commit run -a to run for all files. However this currently raises a lot of mypy and pylint errors. Aware that some outstanding PRs will fix some of these issues, but if this is merged we should capture that as an issue.

@tennlee tennlee merged commit af1b1f7 into nci:develop Oct 25, 2023
@John-Sharples John-Sharples deleted the 73-precommit branch October 25, 2023 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants