Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ncks "append mode" is broken #28

Closed
kwilcox opened this issue May 22, 2017 · 1 comment
Closed

ncks "append mode" is broken #28

kwilcox opened this issue May 22, 2017 · 1 comment

Comments

@kwilcox
Copy link
Member

kwilcox commented May 22, 2017

The code to retrieve the version of NCO is currently broken:

  File "/home/kwilcox/miniconda3-py36/envs/packrat35/lib/python3.5/site-packages/nco/nco.py", line 224, in get
    nco_version = self.version()
  File "/home/kwilcox/miniconda3-py36/envs/packrat35/lib/python3.5/site-packages/nco/nco.py", line 364, in version
    ncra_help)
  File "/home/kwilcox/miniconda3-py36/envs/packrat35/lib/python3.5/re.py", line 173, in search
    return _compile(pattern, flags).search(string)
TypeError: cannot use a string pattern on a bytes-like object

When specifying the append flag (-A) in ncks, the version() function is called resulting in errors. We need some test coverage for the append ncks functionality!

$ python
Python 3.5.3 | packaged by conda-forge | (default, Feb  9 2017, 14:37:12) 
[GCC 4.8.2 20140120 (Red Hat 4.8.2-15)] on linux
@kwilcox
Copy link
Member Author

kwilcox commented May 22, 2017

Working on a PR...

kwilcox added a commit to kwilcox/pynco that referenced this issue May 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant