Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Context aware busy handler #145

Closed
ncruces opened this issue Sep 3, 2024 · 1 comment · Fixed by #146
Closed

Context aware busy handler #145

ncruces opened this issue Sep 3, 2024 · 1 comment · Fixed by #146
Assignees
@ncruces
Labels
enhancement New feature or request

Comments

@ncruces
Copy link
Owner

ncruces commented Sep 3, 2024 •
edited
Loading

In 7ee023d, @NyaaaWhatsUpDoc tried to make busy handlers context aware.

The implementation predates ed932ee (which already makes the busy handling process as awhole interruptible) and uses the wrong context, but is fundamentally a good idea.

This can be implemented transparently for BusyTimeout, but is a breaking change for BusyHandler.
@ncruces ncruces added the enhancement New feature or request label Sep 3, 2024
ncruces added a commit that referenced this issue Sep 3, 2024
@ncruces
Issue #145.
cf7b89d
@ncruces
Copy link
Owner Author

ncruces commented Sep 3, 2024

Defer BusyHandler change to the next "major" version.

@ncruces ncruces self-assigned this Sep 3, 2024
ncruces added a commit that referenced this issue Sep 3, 2024
@ncruces
Fix #145.
f4421ed
@ncruces ncruces mentioned this issue Sep 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ncruces ncruces

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Context aware busy handler. ncruces/go-sqlite3
1 participant
@ncruces