Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Action integration of remote testing of NASIS functionality #152

Closed
brownag opened this issue Jan 5, 2021 · 1 comment · Fixed by #236
Closed

GitHub Action integration of remote testing of NASIS functionality #152

brownag opened this issue Jan 5, 2021 · 1 comment · Fixed by #236
Labels
NASIS-local This tag is used for pull requests, issues, discussions etc. for soilDB local NASIS functions

Comments

@brownag
Copy link
Member

brownag commented Jan 5, 2021

Currently, bugs and unintended behavior sneaks into NASIS functionality due to the issues with populating selected set with sufficiently diverse data, and the lack of a local NASIS install when we are testing on remote servers. The recent work to switch over to DBI for handling ODBC connections will soon allow for us to use RSQLite instead of ODBC, and point at a file on the local drive, to "simulate" a NASIS local database on remote/cooperator machines.

A few longer-term issues following on from #146 and #149

.Rda stored as artifact of R CMD check GitHub Action

An Rdata object can be stored containing the results of running [defined] methods. A good list was identified based on the files impacted by PR #149. This can provide targets that are used to verify "correct" functionality of NASIS if it is run against a branch known to be good and working.

Presence of NASIS-local tag triggers comparison against master

I recently created the NASIS-local tag to tag changes that impact the local NASIS database access functionality. This includes anything that alters the queries that target the NASIS local database, or in the future, a SQLite or similar backend via an alternative DBI driver.

Automatic tagging of NASIS-local

We could specify a list of files that automatically trigger the more stringent requirements -- i.e. comparison against a known target given a defined data source (probably in the form of a minimally populated .sqlite file)

@brownag brownag added the NASIS-local This tag is used for pull requests, issues, discussions etc. for soilDB local NASIS functions label Jan 5, 2021
@brownag
Copy link
Member Author

brownag commented Mar 30, 2021

Latest version of the routine to run NASIS fetch/get_ methods is https://github.com/ncss-tech/soilDB/blob/master/misc/run-all-NASIS-get-methods.R

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NASIS-local This tag is used for pull requests, issues, discussions etc. for soilDB local NASIS functions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant