Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: add 'close' to scroll strategy options #53

Closed
willshowell opened this issue Oct 20, 2017 · 0 comments · Fixed by #77
Closed

Feat: add 'close' to scroll strategy options #53

willshowell opened this issue Oct 20, 2017 · 0 comments · Fixed by #77
Labels
blocked: next cdk release feature

Comments

@willshowell
Copy link
Contributor

willshowell commented Oct 20, 2017 •
edited
Loading

This is dependent on the resolution of issue in #52 and potentially an upgraded CDK dependency.

It will be important to ensure that the isOpen() and isPopoverOpen() methods return correctly after a popover has been closed via scrolling. That probably will require subscribing to detachments instead of imperatively setting the properties.

Also update the api.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked: next cdk release feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: support cdk 5.0.0-rc0 and add close scroll strategy ncstate-sat/popover
1 participant
@willshowell