Merge pull request #233 from ndunand/dev

Improve tooltip display
ndunand · Nov 12, 2024 · 684567c · 684567c
2 parents f8828bf + cda36ae
commit 684567c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 9 deletions.
diff --git a/lang/en/choicegroup.php b/lang/en/choicegroup.php
@@ -57,6 +57,7 @@
 $string['choicegroupname'] = 'Group choice name';
 $string['choicegroupopen'] = 'Open';
 $string['choicegroupoptions'] = 'Choice options';
+$string['choicegroupoptions_description'] = 'Define available group options for participants';
 $string['choicegroupoptions_help'] = 'Here is where you specify which groups participants can choose from.
 
 The list on the left displays all available groups and groupings. To add one or several groups, select these from the list and click "Add". To add all groups from a grouping, select the grouping and click "Add".

diff --git a/mod_form.php b/mod_form.php
@@ -151,15 +151,10 @@ public function definition() {
         $mform->addElement('header', 'groups', get_string('groupsheader', 'choicegroup'));
         $mform->addElement('html', '<fieldset class="clearfix">
                 <div class="fcontainer clearfix">
-                <div id="fitem_id_option_0" class="fitem fitem_fselect ">
-                <div class="fitemtitle"><label for="id_option_0">' . get_string('groupsheader', 'choicegroup') .
-            '</label><span class="helptooltip"><a href="' . $CFG->wwwroot .
-            '/help.php?component=choicegroup&amp;identifier=choicegroupoptions&amp;lang=' . current_language() .
-            '" title="' . get_string('choicegroupoptions_help', 'choicegroup') .
-            '" aria-haspopup="true" target="_blank"><img height="24px" width="24px" src="' . $CFG->wwwroot . '/theme/image.php?theme='
-            . $PAGE->theme->name . '&component=core&image=help" alt="' .
-            get_string('choicegroupoptions_help', 'choicegroup') .
-            '" class="iconhelp"></a></span></div><div class="felement fselect">
+                <label for="fitem_id_option_0" class="fitemtitle">'
+                    . get_string('choicegroupoptions_description', 'choicegroup') . '</label>
+                <div id="fitem_id_option_0" name="fitem_id_option_0" class="fitem fitem_fselect ">
+                <div class="felement fselect">
                 <div class="tablecontainer">
                 <table>
                     <tr class="row">
@@ -168,6 +163,7 @@ public function definition() {
                     </tr>
                     <tr class="row">
                         <td style="vertical-align: top" class="col-5">');
+        $mform->addHelpButton('groups', 'choicegroupoptions', 'choicegroup');
 
         $mform->addElement('html', '<select class="col-12" id="availablegroups" name="availableGroups" multiple size=10>');
         foreach ($groupings as $groupingid => $grouping) {