-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some more cleanups and making the content-type override work the correct way #112
Conversation
…wn URI that cannot normally give an URISyntaxException
…e or Ant task without breaking tests and violating the specifications
I'm just not sure about this. Remind me again what you're trying to accomplish? |
Oh sorry, forgot to comment on this one. 9e06163: removes files that are left-overs from some un-clean patch applying and most important |
Sorry, I'm just having trouble getting my head around the content type patch. By my first reading, you've introduced forced-content-type that basically shadows content-type and maybe gets used preferentially. What's the use case where content-type doesn't do the right thing, but forced-content-type does? If you're reading a file: URI, I'd expect content-type to do the right thing. If you're reading from an http: URI but you want to override the server-provided content type, I'd like to understand why. |
I had a use-case in mind when I implemented it, I'm just not 100% sure what it was. Afair, one usecase is to force the content being treated as text or force the content to being encoded with base64, if you simply manually know better than the detection or if the webserver sends a wrong content type which could pretty well happen out there. The patch just enables you to specify from command line as parameter or from the ant task the content type to use which is transported as forced-content-type. |
Apologies. I didn't get this merged in a reasonable time and there's been too much divergence now. If you've been keeping your patch up-to-date feel free to send it again and I'll try to get my head around it. |
No description provided.