fix: Fixed CI to use secrets instead of vars where applicable

near · Nov 14, 2023 · 50f3cfd · 50f3cfd
1 parent 4bb16ae
commit 50f3cfd
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 14 deletions.
diff --git a/.github/workflows/deploy-production.yml b/.github/workflows/deploy-production.yml
@@ -24,5 +24,5 @@ jobs:
             network-config "${{ vars.NEAR_CONTRACT_PRODUCTION_NETWORK }}" \
             sign-with-plaintext-private-key \
               --signer-public-key "${{ vars.NEAR_CONTRACT_PRODUCTION_ACCOUNT_PUBLIC_KEY }}" \
-              --signer-private-key "${{ vars.NEAR_CONTRACT_PRODUCTION_ACCOUNT_PRIVATE_KEY }}" \
+              --signer-private-key "${{ secrets.NEAR_CONTRACT_PRODUCTION_ACCOUNT_PRIVATE_KEY }}" \
             send
diff --git a/.github/workflows/deploy-staging.yml b/.github/workflows/deploy-staging.yml
@@ -27,7 +27,7 @@ jobs:
             network-config "${{ vars.NEAR_CONTRACT_STAGING_NETWORK }}" \
             sign-with-plaintext-private-key \
               --signer-public-key "${{ vars.NEAR_CONTRACT_STAGING_ACCOUNT_PUBLIC_KEY }}" \
-              --signer-private-key "${{ vars.NEAR_CONTRACT_STAGING_ACCOUNT_PRIVATE_KEY }}" \
+              --signer-private-key "${{ secrets.NEAR_CONTRACT_STAGING_ACCOUNT_PRIVATE_KEY }}" \
             send
 
       - name: Install cargo-near CLI
@@ -39,5 +39,5 @@ jobs:
             network-config "${{ vars.NEAR_CONTRACT_STAGING_NETWORK }}" \
             sign-with-plaintext-private-key \
               --signer-public-key "${{ vars.NEAR_CONTRACT_STAGING_ACCOUNT_PUBLIC_KEY }}" \
-              --signer-private-key "${{ vars.NEAR_CONTRACT_STAGING_ACCOUNT_PRIVATE_KEY }}" \
+              --signer-private-key "${{ secrets.NEAR_CONTRACT_STAGING_ACCOUNT_PRIVATE_KEY }}" \
             send
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -3,26 +3,30 @@ on:
   workflow_call:
 
 jobs:
-  fmt:
-    name: Check code formatting
+  code-formatting:
+    name: Code Formatting
     runs-on: ubuntu-latest
     steps:
       - name: Checkout repository
         uses: actions/checkout@v2
-      - name: Unit tests
-        run: |
-          cargo fmt --check
+      - run: cargo fmt --check
 
-  quality-control:
-    name: Quality control checks
+  code-linter:
+    name: Code Linter
     runs-on: ubuntu-latest
     steps:
       - name: Checkout repository
         uses: actions/checkout@v2
-      - uses: Swatinem/rust-cache@v1
-      - name: Linter
+      - name: Run cargo clippy
         run: |
           rustup component add clippy
           cargo clippy --all-features --workspace --tests -- --warn clippy::all --warn clippy::nursery
-      - name: Unit tests
+
+  tests:
+    name: Tests
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v2
+      - name: Run cargo test
         run: cargo test
diff --git a/.github/workflows/undeploy-staging.yml b/.github/workflows/undeploy-staging.yml
@@ -21,5 +21,5 @@ jobs:
             network-config "${{ vars.NEAR_CONTRACT_STAGING_NETWORK }}" \
             sign-with-plaintext-private-key \
               --signer-public-key "${{ vars.NEAR_CONTRACT_STAGING_ACCOUNT_PUBLIC_KEY }}" \
-              --signer-private-key "${{ vars.NEAR_CONTRACT_STAGING_ACCOUNT_PRIVATE_KEY }}" \
+              --signer-private-key "${{ secrets.NEAR_CONTRACT_STAGING_ACCOUNT_PRIVATE_KEY }}" \
             send