feat: encrypt user credentials in Datastore #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volovyks
approved these changes
Apr 26, 2023
DavidM-D
approved these changes
Apr 26, 2023
| @@ -40,6 +40,14 @@ You also need a Ed25519 key pair that you can generate by running `cargo run -- | |||
|
|
|||
| Now save it to GCP Secret Manager under the name of your choosing (e.g. `mpc-recovery-key-prod`). This name will be referred to as `GCP_SM_KEY_NAME`. | |||
|
|
|||
| You also need to grab the AES cipher key that was printed after `Cipher 0:`; it should like this: | |||
There was a problem hiding this comment.
Do we need both this and the JSON private key?
There was a problem hiding this comment.
Yeah, one is for encryption, and the other is for multi-party stuff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #134
aes-gcm is a pretty poor choice for this, but I needed something high-level due to time constraints. Let me know if there is a good alternative.
Ignoring nonce for now, but we should probably use it to salt the results