-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serialize contract with borsh #734
Conversation
@ChaoticTempest it is failing with |
We can choose another approach, read it as env::input(), not a function parameter. Example from sputnik. I have not looked yet, but Illya suggested taking a look at the Aurora contract. |
@volovyks so I tested how much gas a 4mb payload (the limit of a transaction) would take. It's about 93TGas, so we at least have 200TGas to use for the rest of the function which is just storing the contract code anyways. It doesn't have to be this efficient quite yet plus this is just an interface the node will be using so we can change it at will |
also, not sure why the multichain-contract test is not running. It should be listening into the the files changes under |
60c32bf
to
3660d89
Compare
Terraform Feature Environment Destroy (dev-734)Terraform Initialization ⚙️
|
3660d89
to
ba883b6
Compare
huh the multichain contract workflow was disabled for some reason |
ba883b6
to
a0af8e5
Compare
Terraform Feature Environment Destroy (dev-734)Terraform Initialization ⚙️
|
.args_json(serde_json::json!({ | ||
"code": &new_wasm, | ||
})) | ||
.args_borsh((current_contract(),)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ChaoticTempest how do additional brackets help here? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Borsh serialization expects an iterable list of args. Adding (T,)
makes it into a tuple type that is iterable
No description provided.