Flat contract errors #735
Closed
Flat contract errors #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So, we're going to run into issues later with this when we get multiple errors being returned from the same function and they're not easily combined. The flat errors I was talking about is not where we have multiple enums, but rather a singular error type with an Error representation similar to workspaces::ErrorRepr. That way we don't need to think about combining errors and just simply give the error code with custom message or wrap from another error |
|
@gagdiez can you take a look at this, please? Not sure what is best. @ChaoticTempest design is more flexible, but it is not visible what category of errors the function returns. |
|
Closing in favour of #757 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.