Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make mainnet only have log level INFO where DEBUG is too spammy #751

Merged
merged 3 commits into from
Jul 30, 2024

Conversation

ChaoticTempest
Copy link
Member

No description provided.

ailisp
ailisp previously approved these changes Jul 29, 2024
Copy link
Member

@ailisp ailisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@ChaoticTempest
Copy link
Member Author

@kmaus-near @ppca let me know if this is good to go with mainnet release before I merge it

@ppca
Copy link
Contributor

ppca commented Jul 30, 2024

I'd prefer keeping DEBUG for now since it might be easier to debug with more information. Like we can ask partners to search their logs and see if they have certain entries to verify if certain things have happened.

@ChaoticTempest
Copy link
Member Author

yeah, but mainnet is where prod is supposed to be at. It's not supposed be where we should be debugging...

But we can keep debug in our mainnet-dev

@ppca ppca merged commit 183acbc into develop Jul 30, 2024
2 checks passed
@ppca ppca deleted the phuong/chore/mainnet-loglevel-info branch July 30, 2024 19:58
Copy link

Terraform Feature Environment Destroy (dev-751)

Terraform Initialization ⚙️success

Terraform Destroy success

Show Destroy Plan


No changes. No objects need to be destroyed.

Either you have not created any objects yet or the existing objects were
already deleted outside of Terraform.

Destroy complete! Resources: 0 destroyed.

Pusher: @ppca, Action: pull_request, Working Directory: ``, Workflow: Terraform Feature Env (Destroy)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants