Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: The priority of searching in the legacy keychain for access keys when signing a transaction has been changed #396

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

FroVolod
Copy link
Collaborator

Resolves #395

@FroVolod
Copy link
Collaborator Author

@race-of-sloths

@race-of-sloths
Copy link

race-of-sloths commented Aug 19, 2024

@FroVolod Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
Weekly streak is on the road, smart strategy! Secure your streak with another PR!

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@frol 2

Your contribution is much appreciated with a final score of 2!
You have received 21 (20 base + 5% lifetime bonus) Sloth points for this contribution

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@frol frol force-pushed the sign-with-legacy-keychain branch from 3414a3f to 9bc1946 Compare August 20, 2024 17:53
Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@race-of-sloths score 2

@frol frol enabled auto-merge (squash) August 20, 2024 17:56
@frol frol merged commit 17bef89 into main Aug 20, 2024
7 checks passed
@frol frol deleted the sign-with-legacy-keychain branch August 20, 2024 18:03
@frol frol mentioned this pull request Aug 20, 2024
frol added a commit that referenced this pull request Aug 21, 2024
## 🤖 New release
* `near-cli-rs`: 0.14.1 -> 0.14.2

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

##
[0.14.2](v0.14.1...v0.14.2)
- 2024-08-21

### Added
- Upgraded cargo-dist to 0.21.1 and enabled Linux ARM64 build
([#397](#397))
- Prioritize searching an access key in the signer account subfolder
(<credentials-dir>/<network>/<account-id>/*.json) in legacy keychain and
then fallback to <credentials-dir>/<network>/<account-id>.json instead
of the other way around
([#396](#396))

### Other
- Fixed the one-liner curl installation command
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).
FroVolod added a commit that referenced this pull request Aug 23, 2024
…der (<credentials-dir>/<network>/<account-id>/*.json) in legacy keychain and then fallback to <credentials-dir>/<network>/<account-id>.json instead of the other way around (#396)

Resolves #395
FroVolod pushed a commit that referenced this pull request Aug 23, 2024
## 🤖 New release
* `near-cli-rs`: 0.14.1 -> 0.14.2

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

##
[0.14.2](v0.14.1...v0.14.2)
- 2024-08-21

### Added
- Upgraded cargo-dist to 0.21.1 and enabled Linux ARM64 build
([#397](#397))
- Prioritize searching an access key in the signer account subfolder
(<credentials-dir>/<network>/<account-id>/*.json) in legacy keychain and
then fallback to <credentials-dir>/<network>/<account-id>.json instead
of the other way around
([#396](#396))

### Other
- Fixed the one-liner curl installation command
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).
FroVolod added a commit that referenced this pull request Aug 23, 2024
…der (<credentials-dir>/<network>/<account-id>/*.json) in legacy keychain and then fallback to <credentials-dir>/<network>/<account-id>.json instead of the other way around (#396)

Resolves #395
FroVolod pushed a commit that referenced this pull request Aug 23, 2024
## 🤖 New release
* `near-cli-rs`: 0.14.1 -> 0.14.2

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

##
[0.14.2](v0.14.1...v0.14.2)
- 2024-08-21

### Added
- Upgraded cargo-dist to 0.21.1 and enabled Linux ARM64 build
([#397](#397))
- Prioritize searching an access key in the signer account subfolder
(<credentials-dir>/<network>/<account-id>/*.json) in legacy keychain and
then fallback to <credentials-dir>/<network>/<account-id>.json instead
of the other way around
([#396](#396))

### Other
- Fixed the one-liner curl installation command
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recreate account issues with keys
3 participants