Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added the ability to save payload for broadcast_tx_commit #413

Merged
merged 6 commits into from
Dec 6, 2024
Merged

feat: Added the ability to save payload for broadcast_tx_commit #413

merged 6 commits into from
Dec 6, 2024

Conversation

FroVolod
Copy link
Collaborator

No description provided.

@FroVolod
Copy link
Collaborator Author

@race-of-sloths

@race-of-sloths
Copy link

race-of-sloths commented Nov 10, 2024 •
edited
Loading

@FroVolod Thank you for your contribution! Your pull request is now a part of the Race of Sloths!

Shows inviting banner with latest news.

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@dj8yfo 8

Your contribution is much appreciated with a final score of 8!
You have received 95 (80 base + 10 monthly bonus + 5% lifetime bonus) Sloth points for this contribution

@dj8yfo received 25 Sloth Points for reviewing and scoring this pull request.

Congratulations @FroVolod! Your PR was highly scored and you completed another monthly streak! To keep your monthly streak make another pull request next month and get 8+ score for it

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths and receive a reward
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@race-of-sloths
Copy link

❌ PR inactive

This PR has been inactive for two weeks. It's now marked as stale.

Tip

If you think it's a mistake, you can restart the bot with include command to proceed 🔄

@dj8yfo dj8yfo assigned dj8yfo and unassigned dj8yfo Dec 5, 2024
@dj8yfo dj8yfo self-requested a review December 5, 2024 13:14
@dj8yfo dj8yfo force-pushed the request-payload-for-broadcast-tx-commit branch 3 times, most recently from 5ebad9a to c3f80b6 Compare December 6, 2024 16:55
@dj8yfo dj8yfo force-pushed the request-payload-for-broadcast-tx-commit branch from c3f80b6 to 1ffc552 Compare December 6, 2024 17:44
@dj8yfo
Copy link
Collaborator

dj8yfo commented Dec 6, 2024

@race-of-sloths score 8

dj8yfo
dj8yfo reviewed Dec 6, 2024
View reviewed changes
src/common.rs
"JSON Request Body:\n{}",
indent_payload(&format!("{:#}", request_payload))
);
if tracing::enabled!(target: "near_teach_me", tracing::Level::INFO) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without this condition, the new side effect of creating the file is also present, when --teach-me flag is not enabled

@dj8yfo dj8yfo force-pushed the request-payload-for-broadcast-tx-commit branch from aa6b87e to 99599df Compare December 6, 2024 18:03
@dj8yfo dj8yfo merged commit 4e8d0f2 into main Dec 6, 2024
11 checks passed
@dj8yfo dj8yfo deleted the request-payload-for-broadcast-tx-commit branch December 6, 2024 18:15
@frol frol mentioned this pull request Dec 6, 2024
Merged
dj8yfo pushed a commit that referenced this pull request Dec 12, 2024
@frol
chore: release v0.16.1 (#421)
63a9762 
## 🤖 New release
* `near-cli-rs`: 0.16.0 -> 0.16.1 (✓ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

##
[0.16.1](v0.16.0...v0.16.1)
- 2024-12-06

### Added

- Added the ability to save payload for broadcast_tx_commit
([#413](#413))
- Get the final CLI command into the shell history with a small helper
setup ([#415](#415))
- Trace configuration for loading wait indicators and --teach-me flag
moved to library ([#417](#417))
- add to devtools workflow
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dj8yfo dj8yfo dj8yfo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
DevTools
Status: Shipped 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FroVolod @race-of-sloths @dj8yfo