Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: handle new rate-limits for querying pools #433

Merged

Conversation

akorchyn
Copy link
Collaborator

@akorchyn akorchyn commented Dec 23, 2024

Closes: #431

  • Added fast-near for testnet
  • Rate limited querying pools to 140 / 30s

Ideally, if Fastnear is stable enough, the user shouldn't be able to hit this limit as we will query information within the pools the user has staked before.
But in case the fastener fails, we would need to query all active pools, which number more than 150.

Network FastNear Non fast near
Testnet < 140 (mostly 0-5) 563 pools
Mainnet < 140 ( mostly 0-5 ) State of contract poolv1.near is too large to be viewed

@race-of-sloths

@race-of-sloths
Copy link

race-of-sloths commented Dec 23, 2024

@akorchyn Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
Weekly streak is on the road, smart strategy! Secure your streak with another PR!

Shows inviting banner with latest news.

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@frolvanya 3
@dj8yfo 13

Your contribution is much appreciated with a final score of 8!
You have received 149 (80 base + 55 weekly bonus + 10% lifetime bonus) Sloth points for this contribution

@frolvanya received 25 Sloth Points for reviewing and scoring this pull request.
@dj8yfo received 25 Sloth Points for reviewing and scoring this pull request.

Another weekly streak completed, well done @akorchyn! To keep your weekly streak and get another bonus make pull request next week! Looking forward to see you in race-of-sloths

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths and receive a reward
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@akorchyn akorchyn changed the title feat: handle new rate-limits for querying pools bugfix: handle new rate-limits for querying pools Dec 23, 2024
src/commands/account/view_account_summary/mod.rs Outdated Show resolved Hide resolved
src/config/migrations.rs Outdated Show resolved Hide resolved
@frolvanya
Copy link
Contributor

@race-of-sloths score 3

@akorchyn akorchyn requested review from frolvanya and dj8yfo December 24, 2024 15:23
Copy link
Contributor

@frolvanya frolvanya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dj8yfo
Copy link
Collaborator

dj8yfo commented Dec 24, 2024

@race-of-sloths score 13

@akorchyn akorchyn merged commit 366c3ee into main Dec 25, 2024
11 checks passed
@akorchyn akorchyn deleted the 431-view-account-summary-method-doesnt-work-on-testnet-network branch December 25, 2024 01:44
@frol frol mentioned this pull request Dec 25, 2024
@PolyProgrammist
Copy link
Collaborator

LGTM. I don't think there should be a separate ConfigV3 struct as it is the same as V2. Though it's ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Shipped 🚀
Development

Successfully merging this pull request may close these issues.

view-account-summary method doesn't work on testnet network
5 participants