feat: create new events page #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shelegdmitriy
added
the
enhancement
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shelegdmitriy
force-pushed
the
feat/events-page
branch
from
894a1d9 to
e11ab8b
Compare
2 tasks
calebjacob
approved these changes
Feb 29, 2024
shelegdmitriy
commented
Mar 1, 2024
| }; | ||
|
|
||
| export const fetchEventsList = async (limit: number, offset: number): Promise<EventsListData> => { | ||
| const queryLimit = `pagination_limit=${limit ?? 10}`; |
There was a problem hiding this comment.
So far we'll show 10 events on the page. If there is more than 10 - there will be a link to view all events. I think it's fine for MVP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #414