Introduce a iframe based fastAuth & Wallet authentication modal #1017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmalcom
added
the
enhancement
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Pessina
requested changes
Feb 29, 2024
src/components/vm/VmInitializer.tsx
Outdated
| @@ -88,6 +88,7 @@ export default function VmInitializer() { | |||
| networkId === 'testnet' | |||
| ? 'http://34.70.226.83:3030/relay' | |||
| : 'https://near-relayer-mainnet.api.pagoda.co/relay', | |||
| walletUrl: 'https://fast-auth-signer-git-upgrade-impr-2ac97a-near-developer-console.vercel.app/', | |||
There was a problem hiding this comment.
Will we point the walletURL to a specific commit in prod? Or it's test code?
There was a problem hiding this comment.
It's for testing of the preview
src/components/vm/VmInitializer.tsx
Outdated
| @@ -192,6 +193,18 @@ export default function VmInitializer() { | |||
| return false; | |||
| }, [saveCurrentUrl, walletModal]); | |||
|
|
|||
| useEffect(() => { | |||
| window.addEventListener( | |||
There was a problem hiding this comment.
Don't we need to clean up this event listener when the component unmount?
Pessina
approved these changes
Feb 29, 2024
charleslavon
approved these changes
Mar 1, 2024
charleslavon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes some little changes to
DesktopNavigation,useSignInRedirectandvmInitializerfiles to initiate our POC, which is an iframe/modal based authentication instead of the page-based authentication method we currently have.cc: @esaminu