Pinned Apps (2 of 2) #1103
Merged
Pinned Apps (2 of 2) #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment emitGatewayEvent
…lement shouldPassGatewayEventProps() to determine component trust
calebjacob
requested review from
jackson-harris-iii,
charleslavon and
shelegdmitriy
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
calebjacob
added
the
feature
| @@ -42,7 +42,7 @@ a:hover { | |||
| } | |||
|
|
|||
| #near-wallet-selector-modal .open { | |||
| z-index: 1001; | |||
| z-index: 5000; | |||
There was a problem hiding this comment.
Need to check is this doesn't break the turn on notifications prompt 🤔
There was a problem hiding this comment.
@shelegdmitriy Fair point. I'd imagine the sign in modal should always take priority over anything else since you have to click the Sign In button to initiate it. Then it would close once you've connected your wallet or canceled.
Are you thinking the notifications prompt needs to render on top of the sign in modal?
shelegdmitriy
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1056
?sidebar=trueto the end of your URL. The pinned UI on theComponentDetailsPageandProfilePagewill only be visible if the sidebar layout is enabled.useGatewayEvents(). This allows our trusted BOS components to emit an event to the gateway when an app is pinned or unpinned. This allows us to update the sidebar UI optimistically as soon as a user clicks on pin or unpin.localStorageto provide an instant loading experience in the sidebar when initially loading the page. The pinned apps are fetched from Social DB on page load and will eventually update your UI andlocalStorageonce the request finishes to always be in sync with what's actually stored on chain (follows the stale-while-revalidate pattern).useGatewayEvents()hook can hopefully be useful for other features down the road.StarandPinactions to show descriptive tooltips on hover. When a user isn't signed in yet, the tooltips will notify the user that they need to sign in first.To test the UI/UX flow:
?sidebar=trueto the URL and go visit theComponentDetailsPagefor any component./near/widget/ComponentDetailsPage?src=potlock.near/widget/Index&sidebar=truePins (X)tab:/near/widget/ProfilePage?accountId=calebjacob.near&sidebar=trueComponentDetailsPageto unpin the app.