Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create metadata handler for blogposts #1111

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

jackson-harris-iii
Copy link
Contributor

Closes: 1094

@jackson-harris-iii jackson-harris-iii added the feature To highlight a PR's description in the 'New Features' changelog section label Apr 12, 2024
Copy link

vercel bot commented Apr 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
near-discovery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 12, 2024 8:09pm
near-discovery-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 12, 2024 8:09pm

@jackson-harris-iii
Copy link
Contributor Author

@charleslavon I do have a question about the implementation here. The metadata handler is currently using the api from near.social which in turn uses social db to grab the posts with a view lookup resulting in a blockchain read every time. Might using our indexers here be a more performant way to do these lookups resulting in a faster lookup and better SEO?

Copy link
Collaborator

@calebjacob calebjacob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question about fetching indexer data instead of the Social DB API. That's definitely worth looking into.

@charleslavon
Copy link
Contributor

charleslavon commented Apr 15, 2024

@jackson-harris-iii api.near.social/get reads from it's cache DB I don't think there's any blockchain view call worth optimizing.

@jackson-harris-iii jackson-harris-iii merged commit 11dbcfe into develop Apr 15, 2024
6 checks passed
@jackson-harris-iii jackson-harris-iii deleted the jh/blog-metadata-handler branch April 15, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature To highlight a PR's description in the 'New Features' changelog section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve NearSocial blogs by setting the header image as an ipfs file attachment
3 participants